Show most popular charms instead of featured from apiv4 #677

hatched · 2014-12-12T21:11:01Z

This branch removes the featured/interesting/new charms from the charm list in the GUI which were being pulled from apiv3 and replaces it with the search results from the 'most popular' charms from apiv4.

…browser to the most popular charm search results

hatched · 2014-12-12T21:11:39Z

To QA

You should no longer see Featured, Interesting, and New in the charmbrowser on initial load. Instead you should see the most popular charms.

kadams54 · 2014-12-12T21:43:23Z

👍 on the code. Found a dupe showing between recommended and others during QA.

Recommended: http://cl.ly/image/2c2P3b1G221Y
Others: http://cl.ly/image/0w0d351V1E0C

Note that juju-gui/precise is in both lists. Once that's fixed, QA is OK.

jujugui · 2014-12-12T21:45:57Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2310/
Test PASSed.

hatched · 2014-12-13T00:33:16Z

I'm going to make some modifications to how this branch works before I land it:

Filter the juju-gui charms out (They are in the GUI why do they need to deploy it again)
Only list popular promulgated charms (Ordered by the users default environment)
Shuffle the list (So that it stays fresh)
Switch to a single list template with the label "Popular"
https://api.jujucharms.com/charmstore/v4/search?limit=10&sort=-downloads&owner=&limit=30&include=charm-metadata&include=bundle-metadata&include=extra-info&include=stats

urosj · 2014-12-13T09:10:20Z

I'd like to chat about this before we implement new planned changes to te
API.

On Saturday, December 13, 2014, Jeff Pihach notifications@github.com
wrote:

I'm going to make some modifications to how this branch works before I
land it:

Filter the juju-gui charms out (They are in the GUI why do they need
to deploy it again)

Only list popular promulgated charms (Ordered by the users default
environment)

Shuffle the list (So that it stays fresh)

Switch to a single list template with the label "Popular"

—
Reply to this email directly or view it on GitHub
#677 (comment).

mitechie · 2014-12-13T13:18:06Z

This involves no no changes to the API
On Dec 13, 2014 4:10 AM, "Uros Jovanovic" notifications@github.com wrote:

I'd like to chat about this before we implement new planned changes to te
API.

On Saturday, December 13, 2014, Jeff Pihach notifications@github.com
wrote:

I'm going to make some modifications to how this branch works before I
land it:

Filter the juju-gui charms out (They are in the GUI why do they need
to deploy it again)

Only list popular promulgated charms (Ordered by the users default
environment)

Shuffle the list (So that it stays fresh)

Switch to a single list template with the label "Popular"

—
Reply to this email directly or view it on GitHub
#677 (comment).

—
Reply to this email directly or view it on GitHub
#677 (comment).

mitechie · 2014-12-13T13:19:36Z

To clarify this is just how the juju GUI will will use the search API
specifically in 1 view
On Dec 13, 2014 8:18 AM, "Rick Harding" rick.harding@canonical.com wrote:

This involves no no changes to the API
On Dec 13, 2014 4:10 AM, "Uros Jovanovic" notifications@github.com
wrote:

I'd like to chat about this before we implement new planned changes to te
API.

On Saturday, December 13, 2014, Jeff Pihach notifications@github.com
wrote:

I'm going to make some modifications to how this branch works before I
land it:

Filter the juju-gui charms out (They are in the GUI why do they need
to deploy it again)

Only list popular promulgated charms (Ordered by the users default
environment)

Shuffle the list (So that it stays fresh)

Switch to a single list template with the label "Popular"

—
Reply to this email directly or view it on GitHub
#677 (comment).

—
Reply to this email directly or view it on GitHub
#677 (comment).

hatched · 2014-12-14T00:12:01Z

Right, @urosj these are only changes to how the GUI will use the data from the query (link) above.

mitechie · 2014-12-15T13:51:43Z

app/store/charmstore-api.js

+        // get the promulgated version in the results list. This conditional
+        // can be removed once that bug is fixed in the charmstore. Est around
+        // the end of Jan 2015
+        if (entity.Meta['extra-info']['bzr-owner'] === 'charmers' &&


it needs to check if the id has a ~ or not

The bzr-owner field doesn't have ~ in it.

I know I mean the id

I am talking of the I'd field

this isn't valid?

…y util method to keep the popular results appearing fresh

jujugui · 2014-12-15T18:55:29Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2311/
Test PASSed.

jujugui · 2014-12-15T21:24:32Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2312/
Test PASSed.

kadams54 · 2014-12-16T15:06:12Z

QA is good now - the changes make it much better. Thanks!

hatched · 2014-12-16T15:07:57Z

Thanks for the reviews and qa's!

jujugui · 2014-12-16T15:08:46Z

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

Show most popular charms instead of featured from apiv4 This branch removes the featured/interesting/new charms from the charm list in the GUI which were being pulled from apiv3 and replaces it with the search results from the 'most popular' charms from apiv4.

Jeff Pihach added 3 commits December 12, 2014 11:31

Remove the 'editorial' results listing and instead default the charm …

c443554

…browser to the most popular charm search results

Filter out the duplicate promulgated results from the new charmstore api

8898f3f

fixed tests from modifications

ceb9f12

mitechie reviewed Dec 15, 2014
View reviewed changes

Jeff Pihach added 2 commits December 15, 2014 11:41

Added a new template for the popular results as well as a shuffleArra…

f8bb887

…y util method to keep the popular results appearing fresh

Test update and additions

04d7f72

Modify charmers duplicate removal to be more robust

246931e

jujugui merged commit aea2d9c into juju:develop Dec 16, 2014

hatched deleted the interesting-charmlist branch January 13, 2015 16:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show most popular charms instead of featured from apiv4 #677

Show most popular charms instead of featured from apiv4 #677

hatched commented Dec 12, 2014

hatched commented Dec 12, 2014

kadams54 commented Dec 12, 2014

jujugui commented Dec 12, 2014

hatched commented Dec 13, 2014

urosj commented Dec 13, 2014

mitechie commented Dec 13, 2014

mitechie commented Dec 13, 2014

hatched commented Dec 14, 2014

mitechie Dec 15, 2014

hatched Dec 15, 2014

mitechie Dec 15, 2014

mitechie Dec 15, 2014

mitechie Dec 15, 2014

jujugui commented Dec 15, 2014

jujugui commented Dec 15, 2014

kadams54 commented Dec 16, 2014

hatched commented Dec 16, 2014

jujugui commented Dec 16, 2014

Show most popular charms instead of featured from apiv4 #677

Show most popular charms instead of featured from apiv4 #677

Conversation

hatched commented Dec 12, 2014

hatched commented Dec 12, 2014

To QA

kadams54 commented Dec 12, 2014

jujugui commented Dec 12, 2014

hatched commented Dec 13, 2014

urosj commented Dec 13, 2014

mitechie commented Dec 13, 2014

mitechie commented Dec 13, 2014

hatched commented Dec 14, 2014

mitechie Dec 15, 2014

Choose a reason for hiding this comment

hatched Dec 15, 2014

Choose a reason for hiding this comment

mitechie Dec 15, 2014

Choose a reason for hiding this comment

mitechie Dec 15, 2014

Choose a reason for hiding this comment

mitechie Dec 15, 2014

Choose a reason for hiding this comment

jujugui commented Dec 15, 2014

jujugui commented Dec 15, 2014

kadams54 commented Dec 16, 2014

hatched commented Dec 16, 2014

jujugui commented Dec 16, 2014