Conversation
Move the asynchronous bundle fetching to the deployer call on dnd Grab bundle.yaml.orig from bundle details page
QAEnsure that you can deploy a bundle by dragging and dropping, as well as through the 'add to canvas' button in the bundle details. At least one QA in a real env, please, since this tests working with the deployer. |
Test FAILed. |
Bah, thought we fixed the notifier widget. Forcing rebuild at http://ci.jujugui.org:8080/job/juju-gui/2335/console |
triggered again but getting suspicious at this point something has been tripped up causing issues. |
entityData.id, | ||
topo.get('env'), | ||
topo.get('db') | ||
// For now, simply send the bundles.yaml.orig file contents to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XXX this?
code is 👍 no QA with one note on adding the XXX to the comment. |
Code looks good, will now QA. |
QA Ok: |
Different failure, trying one more time to confirm: http://ci.jujugui.org:8080/job/juju-gui/2337/ |
Tests passed in most recent run. Thanks all |
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
Test PASSed. |
Fix bundle deploying This branch utilizes the bundles.yaml.orig file to deploy the bundles, rather than the bundle data as returned by the charm store. It also fixes the inability to drag-and-drop a bundle.
This branch utilizes the bundles.yaml.orig file to deploy the bundles, rather than the bundle data as returned by the charm store. It also fixes the inability to drag-and-drop a bundle.