This repository has been archived by the owner on May 12, 2021. It is now read-only.
Add apiv4 bundle id support to deploy-target #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To QA
|
|
Test FAILed. |
|
Spurious failure, running manually. |
|
👍 QA okay - works like a dream, tried a few different bundles. |
|
Passed when ran manually http://ci.jujugui.org:8080/job/juju-gui/2373/ |
| deploying a bundle via the deployer. | ||
|
|
||
| @method getBundleYAML | ||
| @param {String} id Bundle id in apiv4 format. |
There was a problem hiding this comment.
I might make it clear we're talking charmstore here, e.g. ... id in v4 charmstore api format.
|
👍 @hatched, thanks for the explanations. |
|
Thanks for the reviews! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Feb 17, 2015
Add apiv4 bundle id support to deploy-target The jujucharms.com website allows users to "add to demo" bundles to play around with. It has had to guess at the apiv3 bundle id for some time now which has caused a number of bugs. This adds apiv4 bundle support to the GUI's deploy-target handler so that jujucharms.com can now use the apiv4 bundle id's.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jujucharms.com website allows users to "add to demo" bundles to play around with. It has had to guess at the apiv3 bundle id for some time now which has caused a number of bugs. This adds apiv4 bundle support to the GUI's deploy-target handler so that jujucharms.com can now use the apiv4 bundle id's.