Add apiv4 bundle id support to deploy-target

[hatched]

The jujucharms.com website allows users to "add to demo" bundles to play around with. It has had to guess at the apiv3 bundle id for some time now which has caused a number of bugs. This adds apiv4 bundle support to the GUI's deploy-target handler so that jujucharms.com can now use the apiv4 bundle id's.

[hatched]

To QA

make devel
visit <host>?deploy-target=bundle/django
It should deploy the bundle.

[jujugui]

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/juju-gui/2372/
Test FAILed.

[hatched]

Spurious failure, running manually.

[makyo]

👍 QA okay - works like a dream, tried a few different bundles.

[hatched]

Passed when ran manually http://ci.jujugui.org:8080/job/juju-gui/2373/

[jaycee]

I might make it clear we're talking charmstore here, e.g. ... id in v4 charmstore api format.

[hatched]

Good idea

[jaycee]

Aren't callbacks usually the last arguments, except maybe context/scope? This reads weirdly to me. I feel like it should be _getBundleYAMLResponse: function(bundle, success, failure).

[hatched]

The arguments which are passed to a bound function are passed first to the function, the function is essentially being curried. This is why when getEntity calls the _getBundleYAMLResponse method the arguments it passes to it get appended after the two callbacks.

[jaycee]

I'm not sure this call is right, based on the def below. It looks like your passing in context first, the callbacks, and no bundle at all to the .bind call on _getBundleYAMLResponse. Am I misreading this?

[hatched]

bind returns a function which executes in the context of the object passed as the first argument. The call signature is bind(context, [arg [, arg[, ...])

[jaycee]

👍 @hatched, thanks for the explanations.

[hatched]

Thanks for the reviews!

[jujugui]

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge