This repository has been archived by the owner on May 12, 2021. It is now read-only.
Reorganizing of the drag and drop dispatching code to handle local charm zips #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,6 +102,10 @@ YUI.add('bundle-import-helpers', function(Y) { | |||
| } | |||
|
|
|||
| // Handle dropping Deployer files on the canvas. | |||
| if (!Y.Lang.isArray(fileSources)) { | |||
There was a problem hiding this comment.
When would this happen? Comment would be nice.
|
Test PASSed. |
| env, | ||
| db | ||
| ); | ||
| // We are going to assume it's a bundle if it's not a zip |
There was a problem hiding this comment.
Curious to see where this goes once we try to support dragging folders, but good for now.
|
👍 thank you! |
|
Thanks for the review! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Jan 22, 2014
To QA: Dragging and dropping from the charmbrowser should work just fine and so should dragging a bundle yaml from your desktop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To QA:
Dragging and dropping from the charmbrowser should work just fine and so should dragging a bundle yaml from your desktop.