This repository has been archived by the owner on May 12, 2021. It is now read-only.
Fixed bug causing dropped charm zip files to be parsed as a bundle deployer file in IE11 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ployer file in IE11
|
Test PASSed. |
|
Test PASSed. |
| var file = { | ||
| // Using a complex name to make sure the extension filtering works | ||
| name: 'foo-bar.baz.zip', | ||
| // This MIME type is used in Chrome and Firefox, see the |
There was a problem hiding this comment.
Grammarian niggle: replace comma with semicolon or period.
|
👍 with ultra trivials. |
|
Thanks for the review! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Jan 27, 2014
To QA this is a long setup process of custom charms, juju etc. We can postpone it until putcharm is a little more stable across the ecosystem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To QA this is a long setup process of custom charms, juju etc. We can postpone it until putcharm is a little more stable across the ecosystem.