Skip to content

Commit

Permalink
Merge pull request #11078 from wallyworld/merge-2.7-20200107
Browse files Browse the repository at this point in the history
#11078

## Description of change

Merge 2.7 with these commits:

#11068 update juju/os dependency for focal support
#11070 fix intermittent TestListAll() failure in axctions

## QA steps

See individual PRs
  • Loading branch information
jujubot committed Jan 7, 2020
2 parents 660f506 + 7b455c5 commit 50f6758
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
name = "github.com/juju/naturalsort"

[[constraint]]
revision = "44115a59837dd6cddf93ee4cfb51e48c7ba8bb73"
revision = "a3d14ebcfc135bea4a3e437176f2ddb50c6ffad4"
name = "github.com/juju/os"

[[constraint]]
Expand Down
12 changes: 11 additions & 1 deletion apiserver/facades/client/action/action_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package action_test
import (
"encoding/json"
"fmt"
"sort"
"testing"
"time"

Expand Down Expand Up @@ -808,7 +809,16 @@ func stringify(r params.ActionResult) string {
if a == nil {
a = &params.Action{}
}
return fmt.Sprintf("%s-%s-%#v-%s-%s-%#v", a.Tag, a.Name, a.Parameters, r.Status, r.Message, r.Output)
// Convert action output map to ordered result.
var keys, orderedOut []string
for k := range r.Output {
keys = append(keys, k)
}
sort.Strings(keys)
for _, k := range keys {
orderedOut = append(orderedOut, fmt.Sprintf("%v=%v", k, r.Output[k]))
}
return fmt.Sprintf("%s-%s-%#v-%s-%s-%v", a.Tag, a.Name, a.Parameters, r.Status, r.Message, orderedOut)
}

func (s *actionSuite) toSupportNewActionID(c *gc.C) {
Expand Down
2 changes: 1 addition & 1 deletion cmd/juju/commands/bootstrap.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ supplying a series argument to '--bootstrap-series'.
An error is emitted if the determined series is not supported. Using the
'--force' option to override this check:
juju bootstrap --bootstrap-series=eoan --force
juju bootstrap --bootstrap-series=focal --force
Private clouds may need to specify their own custom image metadata and
tools/agent. Use '--metadata-source' whose value is a local directory.
Expand Down
8 changes: 7 additions & 1 deletion environs/testing/tools.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,13 @@ import (
)

// toolsltsseries records the known ubuntu lts series.
var toolsLtsSeries = series.SupportedLts()
var toolsLtsSeries = supportedJujuSeries()

func supportedJujuSeries() []string {
supportedJujuSeries := set.NewStrings(series.SupportedJujuControllerSeries()...)
esmSupportedJujuSeries := set.NewStrings(series.ESMSupportedJujuSeries()...)
return supportedJujuSeries.Union(esmSupportedJujuSeries).Values()
}

// ToolsFixture is used as a fixture to stub out the default tools URL so we
// don't hit the real internet during tests.
Expand Down

0 comments on commit 50f6758

Please sign in to comment.