Cleanup the state package around watchers. #10491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
charmsSuite.TestCharmsServedSecurely malformed url !!build!! |
achilleasa
approved these changes
Aug 8, 2019
|
|
1 similar comment
|
|
manadart
reviewed
Aug 12, 2019
| if hub == nil { | ||
| ws.StartWorker(txnLogWorker, func() (worker.Worker, error) { | ||
| return watcher.New(st.getTxnLogCollection()), nil | ||
| ws.StartWorker(txnLogWorker, func() (worker.Worker, error) { |
There was a problem hiding this comment.
Do we care that none of these StartWorker calls are error checked?
There was a problem hiding this comment.
A little, because it has been the cause of a few hard to determine bugs. Should get to it sometime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the initial split of the watcher type into the txnwatcher and the hubwatcher the old watcher was kept around for the state.Open method. Since then we refactored again to use OpenController, which made sure that there is only ever one low level watcher polling the database for changes.
However state.Open was not cleaned up. This branch removes the state.Open function, and also the watcher type from the state/watcher package.
The DeadWatcher is now a hubwatcher type rather than a watcher. Also there were a bunch of tests that were testing isolation across connections, which really aren't needed, so they have also been cleaned up.