Fixes lp#1830949: add-k8s validation for user supplied cloud/region #10523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Aug 15, 2019
cmd/juju/caas/add.go
Outdated
| if givenRegion != "" || givenCloud != detectedRegion { | ||
| // If givenRegion is empty, then givenCloud may be a region. | ||
| // Check that it is not a region. | ||
| return errors.Errorf("given cloud %q was different to the detected cloud %q: re-run the command without specifying the cloud", givenCloud, detectedCloud) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
'add-k8s' tries to detect cloud/region. However, for the cases when the command cannot detect the cloud, it relies on user input.
Previously, if the user supplied cloud/region but the command successfully detected what cloud/region to use, user input was ignored and not even validated.
This PR checks user input when cloud/region is detected and if there is a mismatch, the user is prompted.
As a drive-by:
Bug reference
https://bugs.launchpad.net/juju/+bug/1830949
https://bugs.launchpad.net/juju/+bug/1839898