Fixes lp#1840205: show default region from client store. #10533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!!build!! |
wallyworld
approved these changes
Aug 19, 2019
| @@ -595,6 +595,10 @@ func (c *AddCAASCommand) validateCloudRegion(ctx *cmd.Context, cloudRegion strin | |||
| } | |||
| return details.CloudType, nil | |||
| } | |||
| if region == "" && details.DefaultRegion != "" { | |||
There was a problem hiding this comment.
For safety we should still check that details.DefaultRegion is in the details.RegionsMap
ie if region is "", set it to default region can continue as before
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
By default, Juju will pick the first region for the clouds that have more than one region. Users can change that to suit their needs and preferences using 'juju default-region' command. This will be the region used by all commands - bootstrap, add-model, credential validations, etc - that care about region if the user does not explicitly specify a region using a --region option at CLI.
Whilst Juju was mostly correctly using the default region when user set it, Juju was not correctly reporting it in 'juju clouds', 'juju show-cloud', etc.
This PR fixes this.
As a drive-by some renamed some variables in tests that were colliding with imported packages names.
QA steps
Bug reference
https://bugs.launchpad.net/juju/+bug/1840205