Introduce v3 command names for run-action and run #10563
Conversation
| Name: "run-action", | ||
| Args: "<unit> [<unit> ...] <action name> [key.key.key...=value]", | ||
| Purpose: "Queue an action for execution.", | ||
| Doc: runDoc, | ||
| }) | ||
| if featureflag.Enabled(feature.JujuV3) { | ||
| info.Name = "run" | ||
| info.Doc = strings.Replace(info.Doc, "run-action", "run", -1) |
There was a problem hiding this comment.
I think it would be good to append a note to the doc like "NOTE: pre-3.0 juju run functionality is provided by juju exec"
There was a problem hiding this comment.
I don't thin we need to do this because this v3 behaviour is strictly opt-in - the user has to enable a feature flag to see it. They are therefore already aware of what they are doing in that sense and what the command names are etc.
| @@ -246,8 +250,8 @@ func ConvertActionResults(result params.ActionResult, query actionQuery) map[str | |||
| return values | |||
| } | |||
|
|
|||
| func (c *runCommand) Run(ctx *cmd.Context) error { | |||
| client, err := getRunAPIClient(c) | |||
| func (c *execCommand) Run(ctx *cmd.Context) error { | |||
There was a problem hiding this comment.
Doesn't look possible with juju/cmd, but ideally we should be able to warn when a deprecated alias is used. Something like "WARN: juju exec will soon supersede juju run".
There was a problem hiding this comment.
Yeah, not really possible. We'll highlight in the juju 3 release notes
wallyworld
force-pushed
the
juju-v3-aliases
branch
from
98839b8
to
d770e56
Compare
|
|
1 similar comment
|
|
Description of change
Add a "juju-v3" feaure flag and start introducing new commands for run-action and run.
juju-action -> juju run
juju run -> juju exec
With flag not enabled, juju run is aliased to juju exec
QA steps
export JUJU_DEV_FEATURE_FLAGS=juju-v3
juju run ....
juju exec ...