[dev] Fix panic when deploying bundles where maps have nil values #10565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version contains a fix for correctly handling nil values in bundle options while checking base bundles for the presence of overlay-specific fields.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The charm.v6 code that checks base bundles for the presence of overlay-specific options had a bug where the validation code would crash if the base bundle provided map entries (e.g. in options) with nil values.
This PR simply bumps the charm.v6 version to bring in the fix from juju/charm#290
Note: this bug only affects dev releases and does not need to be back-ported to 2.6 as 2.6 does not use the same code path.
QA steps
Try to deploy the following bundle with the latest edge snap (with --dry-run)
to verify it crashes. Then deploy the same with a juju binary built from
this PR to verify that it does not crash (you will get unknown option errors as
the options are bogus)
Bug reference
https://bugs.launchpad.net/juju/+bug/1841105