Mongo controller integration tests #10651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following adds tests done by @howbazaar to the newly updated released version of the integration tests. As a drive by add the juju controller version to the output so it's very obvious what we're attempting to bootstrap.
achilleasa
approved these changes
Sep 24, 2019
| START_TIME=$(date +%s) | ||
| if [ -n "${BOOTSTRAP_REUSE}" ]; then | ||
| echo "====> Reusing bootstrapped juju" | ||
| echo "====> Reusing bootstrapped juju ($(green "${version}"))" |
There was a problem hiding this comment.
Side-note for future improvements: it would be cool if we could also list the provider name when bootstrapping/destroying
There was a problem hiding this comment.
YES!
Good shout, I'll do that next time.
|
|
|
Let's find a place to note things like this. Is there a place to stick bugs
maybe?
…On Tue, Sep 24, 2019 at 6:56 AM Achilleas Anagnostopoulos < ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In tests/includes/juju.sh
<#10651 (comment)>:
> START_TIME=$(date +%s)
if [ -n "${BOOTSTRAP_REUSE}" ]; then
- echo "====> Reusing bootstrapped juju"
+ echo "====> Reusing bootstrapped juju ($(green "${version}"))"
Side-note for future improvements: it would be cool if we could also list
the provider name when bootstrapping/destroying
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10651?email_source=notifications&email_token=AAASRC7FIWLOKTYJJEPWW6LQLHW6TA5CNFSM4IZ52LY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFWK24I#pullrequestreview-292334961>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAASRC3QDPVICFEXCQEP3KLQLHW6TANCNFSM4IZ52LYQ>
.
|
|
@mitechie I'd recommend a launchpad bug on the juju project with "shell-ci" as a tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The following adds tests done by @howbazaar to the newly updated
released version of the integration tests.
As a drive by add the juju controller version to the output so it's
very obvious what we're attempting to bootstrap.
See original code howbazaar:mongo-memory-profile-ci-test
QA steps
cd tests ./main.sh controller