Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Space ID Upgrade for CAAS #10751

Merged
merged 4 commits into from Oct 18, 2019

Conversation

manadart
Copy link
Member

Description of change

This patch augments the upgrade step for updating addresses to use space ID instead of name and provider ID.

The addresses in collections cloudservices and cloudcontainers are now updated. These will not have space names as CAAS is currently space-less, but they have the "0" space ID added.

QA steps

  • Bootstrap a CAAS model and deploy any unit(s)/bundle.
  • Update the operator image using the make job from this patch.
  • Run juju upgrade-controller and observe success without error.

Documentation changes

None.

Bug reference

N/A

@manadart
Copy link
Member Author

@manadart manadart changed the title Address space id upgrade caas Address Space ID Upgrade for CAAS Oct 17, 2019
Copy link
Contributor

@achilleasa achilleasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, running QA steps

state/upgrades.go Outdated Show resolved Hide resolved
state/upgrades.go Outdated Show resolved Hide resolved
Copy link
Contributor

@achilleasa achilleasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA pass

@manadart
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit db53055 into juju:develop Oct 18, 2019
@manadart manadart deleted the address-space-id-upgrade-caas branch October 18, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants