Add action logs to model export #10785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
export-action-logs
branch
3 times, most recently
from
ff37b1b
to
c4bea85
Compare
hpidcock
reviewed
Oct 24, 2019
hpidcock
approved these changes
Oct 24, 2019
wallyworld
force-pushed
the
export-action-logs
branch
from
c4bea85
to
ea26595
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add action logs to model export.
Also, as a driveby, limit the log count just in case an action wants to misbehave.
QA steps
run a charm with an action which logs messages
juju dump-model and look at the yaml to see the logs included