Return Space-Less API Server Addresses to Consumers #10886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
information instead of attempting to resolve it. - Consumers don't care about space information, just where to reach the API servers. - For a space-less model such as k8s, added to a space-aware controller such as MAAS, the model does not have the spaces loaded to look up, which results in errors.
manadart
changed the title
manadart
commented
Nov 8, 2019
| @@ -91,6 +91,10 @@ func IsUpgradeInProgressError(err error) bool { | |||
| // the user) has been migrated to a different controller. | |||
| type RedirectError struct { | |||
| // Servers holds the sets of addresses of the redirected servers. | |||
| // TODO (manadart 2019-11-08): Change this to be either MachineHostPorts | |||
There was a problem hiding this comment.
This seems OK to omit for now. These addresses are parsed rather than resolved by lookup.
|
|
jujubot
added a commit
that referenced
this pull request
Nov 8, 2019
#10887 ## Description of change - Fixes a comment typo in `add-cloud` help text. - Removes interface and test implementation no longer used following #10886 ## QA steps No functional changes; tests pass ## Documentation changes None. ## Bug reference https://bugs.launchpad.net/juju/+bug/1851801
jujubot
added a commit
that referenced
this pull request
Nov 9, 2019
#10890 ## Description of change Merge from 2.7 bringing forward: - #10887 from manadart/2.7 - #10886 from manadart/2.7 - #10879 from jujubot/increment-to-2.7-rc3 - #10872 from hmlanigan/containers - #10875 from wallyworld/fix-doc-link - #10866 from ycliuhw/fix/intermittent-crd-test - #10869 from SimonRichardson/backport-track-branch - #10868 from manadart/2.7-openstack-storage-az - #10865 from wallyworld/features-from-develop - #10863 from wallyworld/microk8s-checks - #10864 from anastasiamac/lp1851441 - #10853 from wallyworld/increment-version-2.7-rc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This patch fixes an error that can be observed when adding a space-less model (such as k8s) to a space-aware controller (such as MAAS).
MAAS decorates addresses with space IDs, which are returned as API addresses to clients and agents. However the space-less model does not have the space information for these to be resolved, so API connections from clients and agents return not-found errors for the address spaces.
Consumers of the API do not care about the address spaces anyway - they are only used to filter based on HA and management space configurations, so when we pass them out, there is no need to resolve the IDs to space names. Instead we just return space-less host/port parameters.
QA steps
add-k8scommand to add this cluster to the controller.statusanddeploycommands do not return not-found errors for spaces.Documentation changes
None.
Bug reference
https://bugs.launchpad.net/juju/+bug/1851763