fix asses_cloud_display #10894
Merged
fix asses_cloud_display #10894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t have, skip if region cannot be found, remove wrongly parsed yaml keys
SimonRichardson
approved these changes
Nov 11, 2019
nammn
force-pushed
the
fix-nw-clouds-display
branch
from
4b5a7f7
to
d24c291
Compare
|
|
2 similar comments
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
didnt work for some time because of multiple reasons:
we added some yaml output, which should not be parsed but still got parsed
juju/cmd/juju/cloud/show.go
Line 159 in 0e8fea3
sometimes regions cannot be parsed
we have new "cloud" types
Bug reference
https://jenkins.juju.canonical.com/view/acceptance-tests/job/nw-clouds-display/1962/console