--force for update- and remove-credential CLI. #10968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal variable.
wallyworld
approved these changes
Nov 29, 2019
|
|
|
unrelated intermittent failure in github.com/juju/juju/worker/uniter/relation.TestPackage |
|
|
anastasiamac
pushed a commit
to anastasiamac/juju
that referenced
this pull request
Dec 9, 2019
juju#10968 ## Please provide the following details to expedite Pull Request review: ### Checklist - [x] Checked if it requires a [pylibjuju](https://github.com/juju/python-libjuju) change? _No API server change, only api CLI client._ - [ ]~~ Added [integration tests](https://github.com/juju/juju/tree/develop/tests) for the PR?~~ - [ ] ~~Added or updated [doc.go](https://discourse.jujucharms.com/t/readme-in-packages/451) related to packages changed?~~ - [x] Do comments answer the question of why design decisions were made? ---- ## Description of change Cloud facade has supported the ability to force update and force remove credentials. This PR catches up corresponding CLI. As a drive-by, I have renamed an internal variable in credential validity to maintain clarity. ## QA steps 1. bootstrap with credential A 2. add model with different credential B 3. remove credential B [will fail because a model uses this credential] 4. force remove credential [success] ## Bug reference Part 2 for https://bugs.launchpad.net/juju/+bug/1852412
This was referenced Dec 9, 2019
jujubot
added a commit
that referenced
this pull request
Dec 10, 2019
#11001 Merge 2.7 forward for: - #10996 from wallyworld/lookup-action-prefix - #10995 from anastasiamac/missing-cons-lp1854510 - #10968 from anastasiamac/add-cred-UR-force - #10987 from howbazaar/2.7-apiserver-agent-ratelimiting - #10992 from howbazaar/2.7-test-races - #10933 from jameinel/2.7-delay-done - #10966 from jameinel/2.7-handle-start-error-1854338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following details to expedite Pull Request review:
Checklist
No API server change, only api CLI client.
Added or updated doc.go related to packages changed?Description of change
Cloud facade has supported the ability to force update and force remove credentials. This PR catches up corresponding CLI.
As a drive-by, I have renamed an internal variable in credential validity to maintain clarity.
QA steps
Bug reference
Part 2 for https://bugs.launchpad.net/juju/+bug/1852412