Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RemoteRelationWatcher facade for CaaS; #11075

Merged

Conversation

ycliuhw
Copy link
Member

@ycliuhw ycliuhw commented Jan 7, 2020

Please provide the following details to expedite Pull Request review:

Checklist

  • [ ] Checked if it requires a pylibjuju change?
  • [ ] Added integration tests for the PR?
  • [ ] Added or updated doc.go related to packages changed?
  • [ ] Do comments answer the question of why design decisions were made?

Description of change

Allow facade RemoteRelationWatcher for CaaS model;

QA steps

$ juju add-model t1 microk8s
$ juju deploy cs:~kelvin.liu/mariadb-k8s-3 --debug -m k1:t1
$ juju offer t1.mariadb-k8s:server


$ juju add-model t2 microk8s

$ juju deploy cs:~juju/mediawiki-k8s-3
$ juju relate mediawiki-k8s:db t1.mariadb-k8s

$ juju deploy cs:~juju/gitlab-k8s-0  --debug
$ juju relate gitlab-k8s t1.mariadb-k8s

$ juju run --unit mariadb-k8s/0 --timeout=30s "relation-list -r 0 --format=json" --operator=true -m k1:t1
["remote-997ed657b36949228aec0862eaf5f3b0/0"]

$ juju run --unit mediawiki-k8s/0 --timeout=30s "relation-list -r 0 --format=json" --operator=true -m k1:t2
["mariadb-k8s/0"]
$ juju run --unit mediawiki-k8s/0 --timeout=30s "relation-get -r 0 - mariadb-k8s --app=True --format=json" --operator=true -m k1:t2
{}

$ juju run --unit gitlab-k8s/0 --timeout=30s "relation-list -r 1 --format=json" --operator=true -m k1:t2
["mariadb-k8s/0"]
$ juju run --unit gitlab-k8s/0 --timeout=30s "relation-get -r 1 - mariadb-k8s --app=True --format=json" --operator=true -m k1:t2
{}

Documentation changes

None

Bug reference

None

@ycliuhw ycliuhw force-pushed the fix/add-support-RemoteRelationWatcher4CaaS branch from d93aa35 to 202cc35 Compare January 7, 2020 01:32
@ycliuhw
Copy link
Member Author

ycliuhw commented Jan 7, 2020

!!build!!

@ycliuhw
Copy link
Member Author

ycliuhw commented Jan 7, 2020

$$merge$$

@jujubot jujubot merged commit 205e11a into juju:2.7 Jan 7, 2020
@ycliuhw ycliuhw deleted the fix/add-support-RemoteRelationWatcher4CaaS branch January 7, 2020 06:38
@ycliuhw ycliuhw mentioned this pull request Jan 8, 2020
jujubot added a commit that referenced this pull request Jan 8, 2020
#11081

## Please provide the following details to expedite Pull Request review:

### Checklist

- <del>[ ] Checked if it requires a [pylibjuju](https://github.com/juju/python-libjuju) change?</del>
 - <del>[ ] Added [integration tests](https://github.com/juju/juju/tree/develop/tests) for the PR?</del>
 - <del>[ ] Added or updated [doc.go](https://discourse.jujucharms.com/t/readme-in-packages/451) related to packages changed?</del>
 - <del>[ ] Do comments answer the question of why design decisions were made?</del>

----

## Description of change

port 2.7 to develop:

- #11075 Allow RemoteRelationWatcher facade for CaaS;
- #11080 [2.7] improve errors when resolving bundle includes;

## QA steps

None


## Documentation changes

None

## Bug reference

None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants