Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude build number for OCI image tag; #11084

Closed
wants to merge 3 commits into from
Closed

Exclude build number for OCI image tag; #11084

wants to merge 3 commits into from

Conversation

ycliuhw
Copy link
Member

@ycliuhw ycliuhw commented Jan 9, 2020

Please provide the following details to expedite Pull Request review:

Checklist

  • [ ] Checked if it requires a pylibjuju change?
  • [ ] Added integration tests for the PR?
  • [ ] Added or updated doc.go related to packages changed?
  • [ ] Do comments answer the question of why design decisions were made?

Description of change

Do not include build number in OCI image tag;

QA steps

$ DOCKER_USERNAME=xxxx JUJU_BUILD_NUMBER=888 make microk8s-operator-update
$ juju bootstrap microk8s k1 --config caas-image-repo=xxxx
# inspect image tag with no build number 888;
$ mkubectl get pod/controller-0 -n controller-k1 -o yaml

Documentation changes

None

Bug reference

None

@ycliuhw ycliuhw force-pushed the fix/officeversion branch 3 times, most recently from 982e88f to b805f7c Compare January 9, 2020 02:02
@ycliuhw
Copy link
Member Author

ycliuhw commented Jan 9, 2020

fix by #11085 instead

@ycliuhw ycliuhw closed this Jan 9, 2020
@ycliuhw ycliuhw deleted the fix/officeversion branch January 9, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyworld wallyworld Awaiting requested review from wallyworld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ycliuhw