Integration Test for CMR Consumer Migration #11155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another controller.
The following additional wait is to ensure that the consuming relation is setup before attempting to migrate it. If you try and do it too quickly then the migration will fail. We could put a sleep in here, but actually it's better to test the full flow of communication as that will be inherently much quicker in the long run, with less failure cases. The only outstanding issue now is that if this does fail, then destroying a controller fails because there are still offers in existence. This causes dangling jujus in the testing infrastructure. I'll solve that in another PR.
|
!!build!! |
SimonRichardson
changed the title
SimonRichardson
approved these changes
Jan 29, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Adds a new integration test to verify migration of a model with consumers of a CMR offered from another controller.
QA steps
Documentation changes
None.
Bug reference
N/A