Changes k8s watcher to use informers. #11161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
reviewed
Jan 30, 2020
hpidcock
reviewed
Jan 30, 2020
wallyworld
reviewed
Jan 30, 2020
hpidcock
reviewed
Jan 30, 2020
hpidcock
reviewed
Jan 30, 2020
ycliuhw
reviewed
Jan 30, 2020
tlm
force-pushed
the
watcher-disconnect
branch
2 times, most recently
from
c43ba91
to
08ebe82
Compare
hpidcock
reviewed
Jan 30, 2020
hpidcock
reviewed
Jan 30, 2020
tlm
force-pushed
the
watcher-disconnect
branch
2 times, most recently
from
a2bb3ed
to
4c76897
Compare
wallyworld
reviewed
Feb 3, 2020
wallyworld
reviewed
Feb 3, 2020
wallyworld
reviewed
Feb 3, 2020
tlm
force-pushed
the
watcher-disconnect
branch
from
4c76897
to
e031b76
Compare
wallyworld
reviewed
Feb 5, 2020
wallyworld
reviewed
Feb 5, 2020
wallyworld
reviewed
Feb 5, 2020
wallyworld
reviewed
Feb 5, 2020
tlm
force-pushed
the
watcher-disconnect
branch
2 times, most recently
from
6e54235
to
f670240
Compare
- This changes introduces the more robust shared index informer for juju. Underneath watchers are still used but with a higher safer level of abstraction
tlm
force-pushed
the
watcher-disconnect
branch
from
f670240
to
35c29ad
Compare
mitechie
force-pushed
the
2.7
branch
2 times, most recently
from
71c2a5a
to
5cec786
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Moves k8swatcher to use shared informers over raw k8s watchers. Benefits here are listing, resuming and connection handling. Also will use a shared cache for fetching objects instead of putting extra load on the API server.
QA steps
Bootstrap juju controller to microk8s. The following steps will then kill the kube-apiserver to mimic connection loss.
Check the logs to make sure we are not seeing any error messages with
k8s event watcher closed, restartingNext step is to manually destroy some workload pods and test the status is still being reported correctly in juju.
Bug reference
https://bugs.launchpad.net/juju/+bug/1859894