'juju status' caches the list of space names. #11260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than mapping from space-id to space-name for each interface, do a single query load, and then pull the space names out of the map.
manadart
reviewed
Feb 29, 2020
|
Has been merged along with a test in #11262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Rather than mapping from space-id to space-name for each interface, do
a single query load, and then pull the space names out of the map.
QA steps
On a controller with many machines (1000 in a model), do 'juju status'. It should return quickly. You can also use 'mongotop' to see that we are making a lot of reads against the spaces collection.
Documentation changes
None.
Bug reference