Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Bump meter status facade version #11413

Merged

Conversation

achilleasa
Copy link
Contributor

Description of change

This PR bumps the MeterStatus facade version after the changes that landed with #11405.

This would not be required under normal circumstances as the agents that are supposed to be calling the V2 methods (provided via a mixin) are guaranteed to be upgraded after the controller. Unfortunately, pylibjuju exposes the agent facades which technically makes it possible for someone to actually try to invoke the new methods on an old controller.

QA steps

Same as #11405

This would not be required under normal circumstances as the agents that
are supposed to be calling the V2 methods (provided via a mixin) are
guaranteed to be upgraded after the controller. Unfortunately, pylibjuju
exposes the agent facades which technically makes it possible for
someone to actually try to invoke the new methods on an old controller.
Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, it's best to do this as we might end up with unforeseen issues.

@achilleasa
Copy link
Contributor Author

!!build!! unrelated transient error.

@achilleasa
Copy link
Contributor Author

$$merge$$

@achilleasa
Copy link
Contributor Author

$$merge$$ (DNS resolution issues)

@jujubot jujubot merged commit 5e1dc8e into juju:develop Apr 6, 2020
@achilleasa achilleasa deleted the dev-bump-meter-status-facade-version branch April 6, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants