vsphere: Remove code to delete cached VMDKs from all datastores #11439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This is vestigial code that should have been removed a while ago - we no longer cache VMDKs in the datastore, instead they're used to create a template VM that new VMs are cloned from.
This deletion is causing problems if the user doesn't have access to the datastore - in that case it fails and blocks controller teardown.
QA steps
Bootstrap a vsphere controller. Tear it down with
--debug
- there shouldn't be any logging fromjuju.provider.vmware
about deleting from datastores.Documentation changes
None
Bug reference
https://bugs.launchpad.net/juju/+bug/1872552