Rename the MongoSnap fields to JujuDBSnap to match snap name. #11475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid future confusion, we want to have the controller config named 'juju-db-snap-channel' because the channel is for the juju-db snap. This also means should we change what the underlying db is, we don't have to change the config name. Although perhaps that is wishful thinking.
wallyworld
approved these changes
Apr 21, 2020
| @@ -60,7 +60,7 @@ type format_2_0Serialization struct { | |||
| SystemIdentity string `yaml:"systemidentity,omitempty"` | |||
| MongoVersion string `yaml:"mongoversion,omitempty"` | |||
| MongoMemoryProfile string `yaml:"mongomemoryprofile,omitempty"` | |||
| MongoSnapChannel string `yaml:"mongosnapchannel,omitempty"` | |||
| JujuDBSnapChannel string `yaml:"juju-db-snap-channel,omitempty"` | |||
There was a problem hiding this comment.
Perhaps can we make this jujudb-snap-channel
The other fields don't have hyphens (they should) and reducing the number we use in this new field looks a little tidier IMO
| // snaps for focal or later. The value is ignored for older releases. | ||
| MongoSnapChannel = "mongo-snap-channel" | ||
| JujuDBSnapChannel = "juju-db-snap-channel" |
There was a problem hiding this comment.
and here wrt other suggestion
| @@ -139,7 +139,7 @@ func (s *AgentConfigUpdaterSuite) TestCentralHubMissing(c *gc.C) { | |||
| *result = params.ControllerConfigResult{ | |||
| Config: map[string]interface{}{ | |||
| "mongo-memory-profile": "default", | |||
| "mongo-snap-channel": controller.DefaultMongoSnapChannel, | |||
| "juju-db-snap-channel": controller.DefaultJujuDBSnapChannel, | |||
|
|
|
@howbazaar I actually considered renaming this as you did here but decided against it in the end given that the other mongo options (e.g. the memory-profile one) start with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid future confusion, we want to have the controller config
named 'juju-db-snap-channel' because the channel is for the juju-db snap.
This also means should we change what the underlying db is, we don't have
to change the config name. Although perhaps that is wishful thinking.