Fix/upgrade-caas-model #11544
Merged
Fix/upgrade-caas-model #11544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
reviewed
May 7, 2020
…ause we copy charm to unit charm dir now;
If the machine that you are trying to manually provision has the 2.8/edge juju snap installed, it introduces a snap service called "snap.juju.fetch-oci". The code was just checking for "juju" in the returned service list. We now look for "jujud-machine" as a service name as any machine that we sould look to provision over SSH would have a machine agent set up if it was provisioned.
Tell k8s that the admission worker's webhook has no side effects so that dry runs work.
This is a state-agnostic type.
A commit which was part of the 2.8 refactoring work messed up the implementation of the handleReboot method. While the method would return the correct error (ErrReboot or ErrRequeAndReboot), the actual reboot request was never queued due to an early return logic bug. This commit makes everything work again and includes additional checks to prevent future regressions.
…xist because 2.7 does not have it;
ycliuhw
force-pushed
the
fix/install-hook-failed
branch
2 times, most recently
from
9753164
to
0027f6c
Compare
4 tasks
wallyworld
approved these changes
May 8, 2020
ycliuhw
force-pushed
the
fix/install-hook-failed
branch
from
2e935a0
to
d91320c
Compare
ycliuhw
force-pushed
the
fix/install-hook-failed
branch
from
e43c6db
to
439ecdf
Compare
|
|
1 similar comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following details to expedite Pull Request review:
Checklist
Checked if it requires a pylibjuju change?Added integration tests for the PR?Added or updated doc.go related to packages changed?Description of change
This PR fixes a few issues on CAAS models upgrading from 2.7 to 2.8:
upgrade-counter)inpodSpecscollection;QA steps
Documentation changes
None
Bug reference
https://bugs.launchpad.net/juju/+bug/1874506
https://bugs.launchpad.net/juju/+bug/1877025