Machine agent tests: increase timeout in TestJobManageModelRunsMinUnitsWorker #11591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sometimes fails because the raft workers take too long to get started, use the longer wait that was added to fix this problem.
|
|
Merged
jujubot
added a commit
that referenced
this pull request
May 19, 2020
#11600 ## Description of change Merge 2.8-rc branch with these commits: #11585 don't write errors when pubsub socket disconnects #11583 k8s pod initialisaton races #11582 increase max wait time for WaitAdance #11573 finish legacy lease removal #11591 increase timeout in machine agent tests #11592 expose engine worker restart time as package variable #11507 add k8s model agent pod #11595 fix caas uniter restart on error #11593 add revoke leases so dead units lose their lease immediately #11594 fix deferreturn and bolt #11599 update deployment name used for model op ## QA steps See individual PRs.
Merged
jujubot
added a commit
that referenced
this pull request
May 19, 2020
#11604 ## Description Merge 2.8 branch with these commits: #11585 don't write errors when pubsub socket disconnects #11583 k8s pod initialisaton races #11582 increase max wait time for WaitAdance #11573 finish legacy lease removal #11591 increase timeout in machine agent tests #11592 expose engine worker restart time as package variable #11507 add k8s model agent pod #11595 fix caas uniter restart on error #11593 add revoke leases so dead units lose their lease immediately #11594 fix deferreturn and bolt #11599 update deployment name used for model op ## QA Se individual PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Now that the agent that gets run in the machine agent tests uses raft leases, the raft workers sometimes take too long to get started and ready, which made
TestJobManageModelRunsMinUnitsWorkersometimes fail. Use the longer timeout (double the LongWait) that other tests in the suite already use.QA steps
Running the test under stress doesn't fail after a lot of runs.
Documentation changes
None
Bug reference
None