Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port stickupkid/unpin machine applications on destroy #11641

Commits on May 27, 2020

  1. Refactor leadership pinning API

    The following re-works the common leadership pinning API. It removes the
    idea that the API is part of a facade and instead defines it's own type,
    one that can move independantly of a facade version. This has been an
    ongoing discussion for sometime, but has concretely formalised to a
    discourse post[1].
    
    The changes are relatively simple, adding new methods for taking a
    application name slice, so calling Pin/Unpin doesn't require a machine
    to talk to. This should give us a lot of flexibility about when and how
    we can call these methods.
    
    1. https://discourse.juju.is/t/common-facade-apis/3081
    SimonRichardson committed May 27, 2020
    Configuration menu
    Copy the full SHA
    1e1e767 View commit details
    Browse the repository at this point in the history
  2. Lift tag higher up the stack

    The tag is required to be higher up the stack in-order to make it
    accessible for external calls to change it depending on their
    requirements.
    SimonRichardson committed May 27, 2020
    Configuration menu
    Copy the full SHA
    12d0293 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Rename methods to be more generic

    The following updates the methods to be a lot more generic as we
    no-longer care about if it's a machine we're dealing with. All we care
    about is the application names, so with this in mind I've updated the
    type correctly, along with tests...
    SimonRichardson committed May 28, 2020
    Configuration menu
    Copy the full SHA
    25f16ee View commit details
    Browse the repository at this point in the history
  2. Merge pull request juju#11631 from SimonRichardson/refactor-leadershi…

    …p-pinning-type
    
    juju#11631
    
    ## Description of change
    
    The following re-works the common leadership pinning API. It removes the
    idea that the API is part of a facade and instead defines its own type,
    one that can move independently of a facade version. This has been an
    ongoing discussion for some time, but has concretely formalised to a
    discourse post[1].
    
    The changes are relatively simple, adding new methods for taking an
    application name slice, so calling Pin/Unpin doesn't require a machine
    to talk to. This should give us a lot of flexibility about when and how
    we can call these methods.
    
    1. https://discourse.juju.is/t/common-facade-apis/3081
    
    ## QA steps
    
    Test pass, this is a mechanical refactoring change
    
    ## Bug reference
    
    https://bugs.launchpad.net/juju/+bug/1879663
    jujubot committed May 28, 2020
    Configuration menu
    Copy the full SHA
    040084f View commit details
    Browse the repository at this point in the history
  3. Unping machine applications on destroy

    During a destruction of a machine application, we should attempt to
    remove any last references to ties for leadership pinning.
    
    The normal destroy flow will attempt to remove the leadership pinnings,
    but will fail if there exists pinnings. Using force will allow this to
    proceed.
    
    The call for removing pinnings is idempotent, so calling it multiple
    times is fine.
    SimonRichardson committed May 28, 2020
    1 Configuration menu
    Copy the full SHA
    041af2e View commit details
    Browse the repository at this point in the history
  4. Fix linting issue

    SimonRichardson committed May 28, 2020
    Configuration menu
    Copy the full SHA
    383e945 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Merge remote-tracking branch 'stickupkid/unpin-machine-applications-o…

    …n-destroy' into port-stickupkid/unpin-machine-applications-on-destroy
    wallyworld committed May 29, 2020
    Configuration menu
    Copy the full SHA
    6f6656e View commit details
    Browse the repository at this point in the history