Fix api/uniter test race and a lint issue #11653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
reviewed
Jun 1, 2020
|
"[LOG] 0:00.680 ERROR juju.cmd.juju.commands invalid JUJU_AGENT_TESTING_OPTIONS env value "": expected "key=value", got """ |
hpidcock
approved these changes
Jun 2, 2020
|
|
1 similar comment
|
|
|
|
7 similar comments
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
5 similar comments
|
|
|
|
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Some api/uniter tests had an issue where the setup created an object used later with the wrong gc.C, leading to a test race.
Also fix an issue where an err was ignored.
QA steps
run unit tests