Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix local charm validation on deploy - should allow only dispatch file too #11666

Merged
merged 1 commit into from Jun 5, 2020
Merged

fix local charm validation on deploy - should allow only dispatch file too #11666

merged 1 commit into from Jun 5, 2020

Conversation

hmlanigan
Copy link
Member

Description of change

Check for a populated hooks dir or a dispatch file when validating a local charm for deployment. One of these is required.

QA steps

$ juju bootstrap localhost

# these 2 charms should succeed, have hooks dir or dispatch file
$ juju deploy ./testcharms/charm-repo/bionic/lxd-profile-alt
$ juju deploy ./testcharms/charm-repo/quantal/category-dispatch

# this charm will fail to deploy 
$ juju deploy ./testcharms/charm-repo/quantal/category
ERROR invalid charm "category": has no hooks nor dispatch file

Bug reference

https://bugs.launchpad.net/juju/+bug/1881839

@hmlanigan
Charm must have dispatch file or popluated hooks dir.
0c04687 
Fixes a bug introduced when the dispatch file was introduced.  Allow for
charms to only have a dispatch file, with no hooks directory.  Add a
small charm for testing.
@manadart
Copy link
Member

manadart commented Jun 3, 2020

Logic and QA all good.

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

$$merge$$

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

4 similar comments
@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

$$merge$$

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

$$merge$$

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

1 similar comment
@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!
$$merge$$

1 similar comment
@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!
$$merge$$

@hpidcock
Copy link
Member

hpidcock commented Jun 5, 2020

!!build!!

@jujubot jujubot merged commit 9b71e46 into juju:2.8 Jun 5, 2020
@hmlanigan
Copy link
Member Author

$$merge$$

@hmlanigan hmlanigan deleted the charm-validation-deploy-bug branch June 5, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manadart manadart manadart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@hmlanigan @manadart @hpidcock @jujubot