Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Step for Link-Layer Devices Named "unsupportedx" #11726

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

manadart
Copy link
Member

@manadart manadart commented Jun 18, 2020

Description of change

This patch adds an upgrade step for version 2.8.1 that removes link-layer data for devices sourced from the EC2 provider with names beginning with "unsupported".

Such devices and addresses duplicate correctly named data sourced directly from the machine, and prevent updates via the new instance-poller logic.

At the same time, the 2.8.0 step for updating address origin is repeated, as this version had a subsequently fixed issue whereby addresses could achieve an empty origin value, regressing the step.

QA steps

  • Bootstrap to AWS with any prior version; I used 2.7 edge.
  • Connect to Mongo and observe entries in the linklayerdevices and ip.addresses collections with names beginning with "unsupported".
  • With this patch, run juju upgrade-controller --build-agent.
  • Check the collections again to ensure that the unsupported devices and addresses are absent.
  • Note also the "provider" origin on docs in the ip.addresses collection, where it was absent before.

Documentation changes

None

Bug reference

N/A

Issues remained in 2.8.0 that could have resulted in addresses with an
empty origin.
data from the EC2 provider with names beginning with "unsupported".
@manadart
Copy link
Member Author

@manadart manadart changed the title 2.8 lld upgrade step Upgrade Step for Link-Layer Devices Named "unsupportedx" Jun 18, 2020
@manadart manadart added the 2.8 label Jun 18, 2020
@manadart
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit b0fb685 into juju:2.8 Jun 18, 2020
@manadart manadart deleted the 2.8-lld-upgrade-step branch June 18, 2020 14:07
jujubot added a commit that referenced this pull request Jun 18, 2020
#11727

Merges forward a single patch from 2.8:
- #11726 from manadart/2.8-lld-upgrade-step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants