Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update juju/testing and use AddExpr instead of AddRegex #11802

Merged
merged 1 commit into from Jul 8, 2020
Merged

Update juju/testing and use AddExpr instead of AddRegex #11802

merged 1 commit into from Jul 8, 2020

Conversation

hpidcock
Copy link
Member

@hpidcock hpidcock commented Jul 6, 2020 •
edited

Description of change

  • Update juju/testing
  • use AddExpr instead of AddRegex

QA steps

Run state tests.

Documentation changes

https://discourse.juju.is/t/multichecker-for-unit-tests/3320

Bug reference

N/A

@hpidcock hpidcock requested a review from howbazaar July 6, 2020 04:22
@hpidcock hpidcock added the 2.8 label Jul 6, 2020
SimonRichardson
SimonRichardson approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a discourse post (doesn't have to be that long; "X does this, use it!") about what this gives you in terms of testing... that way people are more likely to use the new methods.

@hpidcock
Copy link
Member Author

hpidcock commented Jul 8, 2020

Can we get a discourse post (doesn't have to be that long; "X does this, use it!") about what this gives you in terms of testing... that way people are more likely to use the new methods.

https://discourse.juju.is/t/multichecker-for-unit-tests/3320

@hpidcock
Copy link
Member Author

hpidcock commented Jul 8, 2020

$$merge$$

@jujubot jujubot merged commit 54ae28d into juju:2.8 Jul 8, 2020
@manadart manadart mentioned this pull request Jul 8, 2020
Merged
jujubot added a commit that referenced this pull request Jul 8, 2020
@jujubot
Merge pull request #11808 from manadart/2.8-into-develop
f6497d5 
#11808

Merge from 2.8 to bring forward:
- #11807 from manadart/2.8-machiner-lld
- #11802 from hpidcock/update-testing-dep
- #11806 from wallyworld/dump-model-partial
- #11805 from jameinel/2.8-dispatch-relative-1885543
- #11796 from SimonRichardson/model-config-input
- #11804 from achilleasa/2.8-manual-provisioning-on-non-amd64-instances-backport
- #11800 from wallyworld/vsphere-absolute-vmfolder
- #11786 from SimonRichardson/juju-config-new-line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonRichardson SimonRichardson SimonRichardson approved these changes

@howbazaar howbazaar Awaiting requested review from howbazaar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hpidcock @SimonRichardson @jujubot