Add CAASApplicationProvisioner facade. #11961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycliuhw
approved these changes
Sep 3, 2020
apiserver/facades/controller/caasapplicationprovisioner/provisioner.go
Outdated
Show resolved
Hide resolved
| @@ -15,6 +15,7 @@ import ( | |||
| const ( | |||
| JujudOCINamespace = "jujusolutions" | |||
| JujudOCIName = "jujud-operator" | |||
| JujuK8sAgentName = "k8sagent" | |||
There was a problem hiding this comment.
have we already split k8sagent from jujud-operator(the build process)?
There was a problem hiding this comment.
Yep that was landed earlier
hpidcock
force-pushed
the
k8s-spike-x
branch
from
956a272
to
f29de60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds CAASApplicationProvisioner facade to provide charm, provisioning info, password setting and unit garbage collection.
The purpose behind API and APIGroup for the apiserver facades is to keep testing of the API and it's required state to just the new facade and not the common facade code.
QA steps
Unit Tests. Need worker to test thoroughly.
Documentation changes
N/A
Bug reference
N/A