Operations/tasks support machines as receivers #11978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
juju-machine-operations
branch
from
4187ae9
to
f8043b2
Compare
ycliuhw
approved these changes
Sep 9, 2020
wallyworld
force-pushed
the
juju-machine-operations
branch
from
f8043b2
to
f93abff
Compare
wallyworld
force-pushed
the
juju-machine-operations
branch
from
f93abff
to
8ab2173
Compare
|
|
jujubot
added a commit
that referenced
this pull request
Sep 11, 2020
#11986 ### Checklist - [ ] Checked if it requires a [pylibjuju](https://github.com/juju/python-libjuju) change? - [ ] Added [integration tests](https://github.com/juju/juju/tree/develop/tests) for the PR? - [ ] Added or updated [doc.go](https://discourse.jujucharms.com/t/readme-in-packages/451) related to packages changed? - [ ] Do comments answer the question of why design decisions were made? ---- ## Description of change This is merging 2.8 into develop, including: prdesc Merge pull request #11985 from mhilton/008-multiwatcher-application-offers prdesc Merge pull request #11980 from jameinel/2.8-log-stderr-warning-1893993 prdesc Merge pull request #11977 from tlm/bug-juju-app-label prdesc Merge pull request #11978 from wallyworld/juju-machine-operations prdesc Merge pull request #11975 from benhoyt/bug-1888409 ## QA steps See individual PRs. ## Documentation changes See individual PRs. ## Bug reference prdesc https://bugs.launchpad.net/juju/+bug/1893993 prdesc https://bugs.launchpad.net/juju/+bug/1892285 prdesc https://bugs.launchpad.net/juju/+bug/1888409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The new opt-in action UX did not handle listing operations, show task etc for juju run actions, since for those the receiver is a machine, and only a unit receiver was supported.
Add support for either unit or machine receivers for processing operations/tasks. Also enhance the operations query to support machines. Usage is opt-in using a feature flag and new "machines" query parameter is optional so no facade bump needed.
QA steps
juju exec --machine 1 hostname
juju operations --machine 1
juju show-task 2 --format yaml