Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subnet placement on Azure #12011

Merged
merged 1 commit into from Sep 17, 2020

Conversation

wallyworld
Copy link
Member

Description of change

Azure supports subnet placement, ie --to subnet=foo
When subnet placement is used, the default hard coded subnets are no longer created.
Also as a driveby pass a params struct in a couple of places to avoid passing too many args to a function.

QA steps

Without placement, confirm that bootstrap and add-model and deploy works as before.

Set up a virtual network (test-vn) with subnets in resource group test-rg

juju add-model --config network=test-rg/test-vn
juju deploy mysql --to subnet=subnet-one

Check the NIC on the machine to confirm the subnet is used

Add a space

juju add-space foo 172.12.1.0/24

Deploy with a space constraint and placement

juju deploy mariadb --constraints="spaces=foo" --to subnet=subnet-one

Copy link
Member

@ycliuhw ycliuhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@wallyworld
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit 072ec48 into juju:develop Sep 17, 2020
@wallyworld
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants