Support subnet placement on Azure #12011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Azure supports subnet placement, ie
--to subnet=foo
When subnet placement is used, the default hard coded subnets are no longer created.
Also as a driveby pass a params struct in a couple of places to avoid passing too many args to a function.
QA steps
Without placement, confirm that bootstrap and add-model and deploy works as before.
Set up a virtual network (test-vn) with subnets in resource group test-rg
juju add-model --config network=test-rg/test-vn
juju deploy mysql --to subnet=subnet-one
Check the NIC on the machine to confirm the subnet is used
Add a space
juju add-space foo 172.12.1.0/24
Deploy with a space constraint and placement
juju deploy mariadb --constraints="spaces=foo" --to subnet=subnet-one