Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juju info add config option #12037

Merged
merged 4 commits into from Sep 23, 2020
Merged

Conversation

hmlanigan
Copy link
Member

Description of change

Allow channels to be displayed again, real vs canned data issue. Instead of latest, the tracks that are latest are an empty string, insert "latest" for display purposes.

Add the ability to display charm config options in the juju info output. Handy to know before deploying.

QA steps

$ export JUJU_DEV_FEATURE_FLAGS="charm-hub"
$ juju bootstrap localhost testme
$ juju add-model seven --config charm-hub-url="https://api.staging.snapcraft.io"
$ juju info apitest-ubuntu-qa --config
name: apitest-ubuntu-qa
charm-id: 4HVy9HLeoMQ0eUALfsvE6ifqtL6DqUPm
summary: |
  juju-qa version of the ubuntu charm.
publisher: Heather Lanigan
supports: focal, xenial, bionic
subordinate: false
store-url: https://api.staging.snapcraft.io/v2/charms/apitest-ubuntu-qa
description: |
  juju-qa version of the ubuntu charm.
channels: |
  latest/stable:     1     (1)  250kB
  latest/candidate:  1     (1)  250kB
  latest/beta:       1     (1)  250kB
  latest/edge:       2     (2)  250kB
settings:
  status:
    type: string
    description: temporary string for unit status
    default: hello
  thing:
    type: string
    description: A thing used by the charm.
    default: "\U0001F381"

though the data received does not contain it.
Print the config settings available for this command on request.
apiserver/facades/client/charmhub/convert.go Show resolved Hide resolved
cmd/juju/charmhub/data.go Outdated Show resolved Hide resolved
cmd/juju/charmhub/infowriter.go Outdated Show resolved Hide resolved
Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$$merge$$

@SimonRichardson
Copy link
Member

$$merge$$

@jujubot jujubot merged commit 2991b49 into juju:develop Sep 23, 2020
@hmlanigan hmlanigan deleted the juju-info-add-config branch September 23, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants