New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test upgrades via github actions #12044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRichardson
force-pushed
the
github-upgrade-test
branch
from
September 23, 2020 10:09
1e13ae2
to
0b3a1b3
Compare
If we use the snap process we can in theory test all the upgrades for a given PR. This should highlight any potential issues during an upgrade process.
SimonRichardson
force-pushed
the
github-upgrade-test
branch
from
September 23, 2020 10:22
0b3a1b3
to
09c212e
Compare
SimonRichardson
force-pushed
the
github-upgrade-test
branch
from
September 23, 2020 15:13
2e63af7
to
f88c81a
Compare
Break if they're not the same, rather than just exiting out early. Boost to 8 minutes to see if that helps Ensure we use the a non cached cmd Handle pipe failures Update model test
SimonRichardson
force-pushed
the
github-upgrade-test
branch
from
September 23, 2020 16:26
766674f
to
0c4597f
Compare
hmlanigan
reviewed
Sep 23, 2020
fi | ||
done | ||
|
||
PANIC=$(juju debug-log --replay --no-tail -m controller | grep "panic" || true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
hmlanigan
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
If we use the snap process we can in theory test all the upgrades for a
given PR. This should highlight any potential issues during an upgrade
process.
QA steps
Github test is valid