Explain why an application name is not valid #12058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes are rather trivial, but the idea is to explain to the user why an application name isn't valid. It attempts to do this in plain english where possible. Rather than falling back to just telling the user about an unexpected character, it first explains that uppercase characters aren't valid, then numbers aren't allowed after hypens. Then if there is something else wrong, explain which character is at fault. Hopefully this will explain the real issue to the user when attempting to interacting with juju.
pengale
reviewed
Sep 28, 2020
achilleasa
reviewed
Sep 28, 2020
achilleasa
reviewed
Sep 28, 2020
achilleasa
reviewed
Sep 28, 2020
The feedback from the original commit was to move this out of juju. This does that, yet keeps the same tests in deploy to ensure we cover that. Although not ideal, they're more integration tests that unit tests, but we are where we are.
achilleasa
approved these changes
Sep 29, 2020
|
|
The go mod tidy was out of sync so this fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The following changes are rather trivial, but the idea is to explain to
the user why an application name isn't valid. It attempts to do this in
plain English where possible.
Rather than falling back to just telling the user about an unexpected
character, it first explains that uppercase characters aren't valid,
then numbers aren't allowed after hyphens. Then if there is something
else wrong, explain which character is at fault.
Hopefully, this will explain the real issue to the user when attempting
to interacting with juju.
QA steps
Bug reference
https://bugs.launchpad.net/juju/+bug/1891418