Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount the primary service account to workload pod if it was defined; #12141

Merged
merged 1 commit into from Oct 16, 2020
Merged

Mount the primary service account to workload pod if it was defined; #12141

merged 1 commit into from Oct 16, 2020

Conversation

ycliuhw
Copy link
Member

@ycliuhw ycliuhw commented Oct 15, 2020

Mount the primary service account to workload pod if it was defined;

Checklist

  • Requires a pylibjuju change
  • Added integration tests for the PR
  • Added or updated doc.go related to packages changed
  • Comments answer the question of why design decisions were made

QA steps

$ juju deploy cs:~charmed-osm/mongodb-k8s --config enable-sidecar=true

$ mkubectl get pod/mongodb-k8s-0 -n t2 -o json | jq '.spec.serviceAccountName,.spec.serviceAccount'
"mongodb-k8s"
"mongodb-k8s"

Documentation changes

No

Bug reference

https://bugs.launchpad.net/juju/+bug/1899987

hpidcock
hpidcock approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@hpidcock hpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycliuhw ycliuhw changed the base branch from 2.8 to 2.7 October 16, 2020 00:01
@ycliuhw ycliuhw changed the base branch from 2.7 to 2.8 October 16, 2020 00:01
@wallyworld
Copy link
Member

$$merge$$

@ycliuhw
Copy link
Member Author

ycliuhw commented Oct 16, 2020

1899987 ServiceAccountName for unit pods

@jujubot jujubot merged commit 5d0442d into juju:2.8 Oct 16, 2020
@wallyworld wallyworld mentioned this pull request Oct 16, 2020
Merged
@ycliuhw ycliuhw deleted the fix/primarySA branch October 16, 2020 00:47
jujubot added a commit that referenced this pull request Oct 16, 2020
@jujubot
Merge pull request #12143 from wallyworld/merge-2.8-20201016a
2eadbec 
#12143

## Please provide the following details to expedite review (and delete this heading)

Merge 2.8 with #12141 
Also drive by fix for bash tests since focal is now the default LTS, not bionic.

## QA steps

See PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpidcock hpidcock hpidcock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ycliuhw @wallyworld @hpidcock @jujubot