Update the upgrade step for 2.9 for charm origin #12404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that more fields have been added to charm origin the upgrade steps should also be added to better reflect that. There is a worrying part that I'm unsure how to solve and that is around people whom are already trying out RC1 and RC2 of 2.9. Offically this won't re-run for them, but is that a bad thing? - The items that actually are mandatory are source, revision, channel and id. These where already in the version 1 of the upgrade. - Platform although important will fallback to the logic to find out what it should be if it's missing. - Type isn't required for charms and is a requirement for bundles, considering we don't store bundles this should be fine. If what I say holds we should be ok.
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Dec 9, 2020
#12427 Merge 2.9 with these PRs #12397 AddPendingResources charhub #12405 move resources api #12404 Update the upgrade step for 2.9 for charm origin #12401 Adds services to service watcher. #12407 Use model-configured default space for NetworkInfo bindings #12411 Save charm origin platform to state #12409 Columnise find to reduce output width #12400 Make UpdateLatestRevisions controller facade work with charmhub #12415 Add Juju-Metadata HTTP headers for charmhub Refresh requests #12410 Charmhub download progress #12413 Charmhub info optional flag #12419 Ensure NetworksForRelation never returns a CAAS container address #12417 fix intermittent failure in upgrade series test #12420 Remove state from common client #12422 Add path and description to ResourceRevision #12423 charmrevisionupdater: remove "handlers" indirection for saving resources #12425 Ensure process limits are correctly set with using juju-db snap No conflicts ## QA steps see PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that more fields have been added to charm-origin, the upgrade steps
should also be added to better reflect that.
There is a worrying part that I'm unsure how to solve and that is around
people who are already trying out RC1 and RC2 of 2.9. Officially this
won't re-run for them, but is that a bad thing?
and id. These were already in version 1 of the upgrade step.
what it should be if it's missing.
considering we don't store bundles this should be fine.
If what I say holds we should be ok.
QA steps
Bootstrap a 2.8.6 and upgrade to 2.9
Deploy a charm...