Progress bar test susceptible to timing failures #12428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The progress bar tests are susceptible to timing failures if running on slow CI boxes. The fix is to pass in a clock to prevent that from happening, so when we run the tests we can pass in our own mock clock which we can target exactly the time we want to test against.
achilleasa
approved these changes
Dec 9, 2020
Which makes me think that upstream doesn't test this on slow machines or how have they never run into this before 🤔 |
|
|
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Dec 10, 2020
#12439 This PR is a forward port of 2.9 into develop. It includes the following: - 97fbb53 (upstream/2.9, origin/2.9, 2.9) Merge pull request #12437 from achilleasa/2.9-set-unit-error-state-when-relation-created-hooks-fail - 0350a3a Merge pull request #12414 from hmlanigan/charmhub-resources-part-2 - c0b7a49 Merge pull request #12434 from SimonRichardson/charmhub-bundle-yaml - 62586b8 Merge pull request #12432 from SimonRichardson/fix-arm-unit-tests - 28b46fc Merge pull request #12433 from hmlanigan/charmhub-caas-common-facade - 18aff0b (manadart/2.9) Merge pull request #12428 from SimonRichardson/fix-progress-bar-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress bar tests are susceptible to timing failures if running on
slow CI boxes. The fix is to pass in a clock to prevent that from
happening, so when we run the tests we can pass in our own mock clock
which we can target exactly the time we want to test against.
QA steps
Tests pass, along with the following still working!