Add IsSecondary to IP Addresses document #12661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
differente from primary NIC addresses.
documents with the IsSecondary field.
SimonRichardson
approved these changes
Feb 22, 2021
|
|
jujubot
added a commit
that referenced
this pull request
Feb 23, 2021
#12668 Merge from 2.9 to bring forward the following patches: - #12663 from manadart/2.9-address-options - #12661 from manadart/2.9-add-is-secondary - #12636 from wallyworld/addk8s-existing - #12643 from SimonRichardson/charmhub-status-fixes - #12656 from benhoyt/run-pebble-as-root Only conflict was the updated version of `juju/description`, which is further ahead on the develop branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new boolean,
IsSecondaryto theipAddressDocin state. Included are changes to handle the field in migrations.Future patches will (1) populate this field when detecting local link-layer devices and (2) use it to ensure that primary addresses are sorted first in calls to
network-get.QA steps
Changes are mechanical at this point. QA for the ultimate feature will accompany future patches.
Unit tests cover changes-to-date.
Documentation changes
None.
Bug reference
Advances https://bugs.launchpad.net/juju/+bug/1863916