Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we validate the model target #12888

Merged
merged 11 commits into from
Apr 19, 2021
Merged

Ensure we validate the model target #12888

merged 11 commits into from
Apr 19, 2021

Commits on Apr 19, 2021

  1. Ensure we validate the model target 

    Instead of using the charm URL, which will be wrong for bases, instead
use only the metadata. The metadata will always be right!

So the following code changes what the purpose of this validate code,
from catching a non container on a container work load. We drop the
series check because we validate that check in other places.
    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    fbb0e56 View commit details
    Browse the repository at this point in the history

  2. Remove platforms from find.

    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    4db5f5e View commit details
    Browse the repository at this point in the history

  3. Attempt to fix some more tests 

    The following fixes tests where it was wrong to assume that you could
craft your way through adding a charm or an application if you didn't
know the series.
    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    b885f3e View commit details
    Browse the repository at this point in the history

  4. Add better comments around validate model target

    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    84932f9 View commit details
    Browse the repository at this point in the history

  5. Prevent the leaking of internal naming 

    Both CAAS and IAAS should not be leaked outside of Juju, so don't do it
in an error message.
    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    9891adf View commit details
    Browse the repository at this point in the history

  6. Validate series/containers during deployment 

    The following ensures that we don't allow --series kubernetes from
happening during a deployment.
    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    09b370a View commit details
    Browse the repository at this point in the history

  7. CharmInfo CAAS vs IAAS tests 

    Adding the correct tests for CAAS for IAAS, previously the code was
written by forcing or cheaking the CAAS charm onto a IAAS model. This
was wrong, badly wrong, instead we should have a test for just CAAS and
IAAS.

I'm deeply concerned that this happens more than it should, even the way
you create a IAAS model is baked in (conn suite), but CAAS is very much
an after thought and there are no symmetrical versions for CAAS.
    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    c6b29a3 View commit details
    Browse the repository at this point in the history

  8. Fix more unit/integration tests 

    Issues where the charm was missing have been fixed.
    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    baf95fd View commit details
    Browse the repository at this point in the history

  9. Fixing state migration import tests 

    We ALWAYS require series for kubernetes in the metadata, so ensure the
tests handle that.
    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    b9e3bf2 View commit details
    Browse the repository at this point in the history

  10. Fix the test typo

    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    319d100 View commit details
    Browse the repository at this point in the history

  11. Fix the deployment of kubeflow-edge

    @SimonRichardson
    SimonRichardson committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    16a006d View commit details
    Browse the repository at this point in the history