Fix for LP:1925721. #12925
Merged
Fix for LP:1925721. #12925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secret name for a Volume must contain `-token`, the app name is not required.
wallyworld
approved these changes
Apr 23, 2021
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Apr 28, 2021
#12930 Merge 2.9 #12911 improve bundle messaging output #12914 Fix gosigma revision in go mod so it is a real revision #12907 Charm with v2 format #12918 juju trust on k8s also creates a cluster role #12917 Do not panic on nil origin Channel. #12920 Correct error message for add-unit on CAAS #12921 Improve error message for invalid API result #12922 Handle internal server errors from charmhub #12923 Ensure we always have an application name #12924 Handle k8s v1 charm inside a bundle #12925 Fix for LP:1925721 #12912 Series-less charms #12919 Tweak display of app version in k8s models #12926 Better error for adding a k8s model with a used namespace #12932 Remove "caas" from error messages #12927 Add scope to trust CLI for k8s models #12928 Suppress charm name in status oci image path #12929 Adds support for missing Kubernetes vars to hook #12933 Fix/lp 1924677 #12934 Fix ssh to a k8s unit in the controller model ``` # Conflicts: # cmd/juju/application/config.go # cmd/juju/application/deployer/deployer_test.go # go.mod # go.sum # scripts/win-installer/setup.iss # snap/snapcraft.yaml # version/version.go ``` ## QA steps See PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosen restrictions on Volume secret names, they only need to include
-token.QA steps
Bug reference
https://bugs.launchpad.net/juju/+bug/1925751