Logs: Ensure we close goroutine on cancel #13119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameinel
reviewed
Aug 6, 2021
| ctx, cancel := context.WithCancel(context.TODO()) | ||
| defer cancel() | ||
|
|
||
| logSource, err := w.config.Facade.StreamModelLog(ctx, latestLogTime) |
There was a problem hiding this comment.
So the net sum of all these changes is just this, right? That if the model migration worker exits before finishing streaming, it will kill the associated goroutine.
Is there a reason to do this around contexts rather than Tombs (which predated context, which is why it is everywhere). I don't have a problem with context, just wondering if we would already have tomb objects around that we weren't properly utilizing.
There was a problem hiding this comment.
I find they serve slightly different purposes. I tend to think that context.Context gives a better API for passing them, where tombs feel like they're internal implementations.
SimonRichardson
force-pushed
the
pass-context
branch
2 times, most recently
from
9c31602
to
b771eec
Compare
manadart
approved these changes
Sep 22, 2021
The following is a WIP to clean up the StreamDebugLogs goroutine if the callee wants to cancel the streaming of the logs. I noticed the TODO whilst threading through a new debug-log parameter.
SimonRichardson
force-pushed
the
pass-context
branch
from
e74fb46
to
8ed1170
Compare
|
|
jujubot
added a commit
that referenced
this pull request
Sep 28, 2021
#13361 Merge from 2.9 to bring forward: - #13360 from wallyworld/simplestreams-compression - #13359 from manadart/2.9-lxd-container-images - #13352 from tlm/aws-instance-profile - #13358 from jujubot/increment-to-2.9.16 - #13354 from wallyworld/refresh-consume-proxy - #13353 from wallyworld/cmr-consume-fixes - #13346 from SimonRichardson/raft-api-client - #13349 from wallyworld/remove-orphaned-cmrapps - #13348 from benhoyt/fix-secretrotate-tests - #13119 from SimonRichardson/pass-context - #13342 from SimonRichardson/raft-facade - #13341 from ycliuhw/feature/quay.io Conflicts (easy resolution): - apiserver/common/crossmodel/interface.go - apiserver/errors/errors.go - apiserver/params/apierror.go - apiserver/testserver/server.go - scripts/win-installer/setup.iss - snap/snapcraft.yaml - version/version.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following cleans up the StreamDebugLogs goroutine if
the callee wants to cancel the streaming of the logs.
I noticed the TODO whilst threading through a new debug-log parameter.
QA steps
Test pass.
Bug reference
https://bugs.launchpad.net/juju/+bug/1644084