Action: Task exit code #13132

SimonRichardson · 2021-07-02T10:15:49Z

The following propagates the task result exit code up to the CLI so that
a user calling juju exec will know that an error occurred in one or
more tasks. Prior to this commit, users would have to inspect every
result which is a bit disappointing for bash style scripting against the
CLI. With this change it should be possible to do the following:

$ juju exec --all 'exit 1'
$ echo $? # should see 1

This makes juju a lot more powerful to sys or ops users.

The code is simple, inspect the result for an exit code. If it exists
propagate it to the CLI and return an error stating the fact that a task
failed.

QA steps

$ juju bootstrap lxd test
$ juju exec -m controller 'exit 1'

The following propagates the task result exit code up to the CLI so that a user calling `juju exec` will know that an error occurred in one or more tasks. Prior to this commit, users would have to inspect every result which is a bit disappointing for bash style scripting against the CLI. With this change it should be possible to do the following: $ juju exec --all 'exit 1' $ echo $? # should see 1 This makes juju a lot more powerful to sys or ops users. The code is simple, inspect the result for an exit code. If it exists propagate it to the CLI and return an error stating the fact that a task failed.

cmd/juju/action/common.go

The wait-for type isn't used any more, so let's just remove it.

The following updates the error message to identify the task failure and the return code of the failure.

cmd/juju/action/common.go

cmd/juju/action/exec_test.go

cmd/juju/action/common.go

Give hints about where to go next if there was a failure. This just improves juju usability.

SimonRichardson · 2021-07-05T11:20:18Z

$$merge$$