Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace missing links. #13194

Merged
merged 3 commits into from Sep 9, 2021
Merged

Replace missing links. #13194

merged 3 commits into from Sep 9, 2021

Conversation

juanmanuel-tirado
Copy link
Contributor

The README.md file contains a bunch of links that do not exist. Actually, they end up pointing to the default https://juju.is/about page. This is a naive review of the non-existing links where I have replaced them with existing pages I consider they contain the expected information from the original link.

I cannot say I found the corresponding page to every link in the previous version. For example, I could not find a page containing the architecture in some sort of diagram or summary. Maybe other pages may be considered to explain the architecture. Most of the changes should be OK until the documentation is complete enough.

Checklist

  • Requires a pylibjuju change
  • Added integration tests for the PR
  • Added or updated doc.go related to packages changed
  • Comments answer the question of why design decisions were made

QA steps

NA

Documentation changes

NA

Bug reference

NA

@juanmanuel-tirado juanmanuel-tirado self-assigned this Jul 26, 2021
@jujubot
Copy link
Collaborator

jujubot commented Jul 26, 2021

Can one of the admins verify this patch?

3 similar comments
@jujubot
Copy link
Collaborator

jujubot commented Jul 26, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Collaborator

jujubot commented Jul 26, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Collaborator

jujubot commented Jul 26, 2021

Can one of the admins verify this patch?

@hpidcock hpidcock added the 2.9 label Aug 16, 2021
Copy link
Member

@hpidcock hpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before landing this PR can we ensure we keep within 80 character line length. Otherwise looks good.

@juanmanuel-tirado
Copy link
Contributor Author

!!build!!

@juanmanuel-tirado
Copy link
Contributor Author

!!merge!!

@juanmanuel-tirado
Copy link
Contributor Author

second attempt

!!merge!!

@juanmanuel-tirado juanmanuel-tirado merged commit e40d76f into juju:2.9 Sep 9, 2021
@juanmanuel-tirado juanmanuel-tirado deleted the patch-1 branch September 9, 2021 14:31
@achilleasa achilleasa mentioned this pull request Sep 13, 2021
jujubot added a commit that referenced this pull request Sep 13, 2021
#13329

This PR forward ports 2.9 into develop. The following PRs are included in this port:
 - Merge pull request #13324 from achilleasa/2.9-add-ovs-integration-test
 - Merge pull request #13328 from manadart/2.9-assess-series-upgrade
 - Merge pull request #13327 from wallyworld/azure-tests-fix
 - Merge pull request #13325 from SimonRichardson/raft-worker-errors
 - Merge pull request #13274 from SimonRichardson/lxd-network-devices-config-host-name
 - Merge pull request #13323 from jujubot/increment-to-2.9.15
 - Merge pull request #13321 from wallyworld/more-secret-metadata
 - Merge pull request #13319 from manadart/2.9-bridge-policy
 - Merge pull request #13320 from SimonRichardson/revert-lxd-changes
 - Merge pull request #13194 from juanmanuel-tirado/patch-1
 - Merge pull request #13318 from hpidcock/fix-1942948
 - Merge pull request #13314 from simondeziel/snap-ack
 - Merge pull request #13297 from achilleasa/2.9-allow-empty-openvswitch-blocks-in-netplan-config
 - Merge pull request #13317 from jujubot/increment-to-2.9.14
 - Merge pull request #13316 from hpidcock/fix-1942948
 - Merge pull request #13296 from ycliuhw/fix/registry-oauth2
 - Merge pull request #13311 from wallyworld/unitagent-missing-charm
 - Merge pull request #13315 from wallyworld/lxd-not-found-fix
 - Merge pull request #13221 from juanmanuel-tirado/status_watch_flag
 - Merge pull request #13312 from wallyworld/remove-txnwatcher-started
 - Merge pull request #13309 from kot0dama/fix-instrospection-posix-shell-2.9

The following files had merge conflicts that had to be resolved (please double-check the changes in last commit):
- caas/kubernetes/provider/bootstrap_test.go
- feature/flags.go
- scripts/win-installer/setup.iss
- snap/snapcraft.yaml
- state/pool.go
- version/version.go
- worker/uniter/relation/state_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants