[JUJU-974] Detect LXD "not found" errors #13957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just "not found". Upstream dependency (LXD 5.0) now returns custom errors instead of os.ErrNotExist.
manadart
changed the title
hmlanigan
approved these changes
Apr 13, 2022
|
hi, is anything blocking this change?, I'm not able to deploy lxd containers and using an older version of lxd is not possible for me since I need fixes only available in lxd's latest/edge . |
jameinel
approved these changes
Apr 14, 2022
|
|
|
Yeah, you really really need to find a way to get on a vaguely modern version of the LXD Go client and get out of string parsing for errors. We really cannot guarantee that we won't be making more changes to those strings as we're actively working on improving errors for our users, moving away from generic error strings. The HTTP return codes are really what you ought to be checking and our client has exposed those since LXD 4.18 (September 2021). |
jujubot
added a commit
that referenced
this pull request
Apr 20, 2022
#13964 New code to fix tests: - state/logs.go InitDbLogsForModel() - issues with getting capped collection info when the database doesn't yet exist. Conflicts: - apiserver/errors/errors.go - apiserver/facades/client/application/application.go - apiserver/facades/client/charmhub/convert.go - apiserver/testserver/server.go - caas/kubernetes/provider/k8s.go - caas/kubernetes/provider/k8s_test.go - cmd/juju/application/bind.go - cmd/juju/application/deployer/bundle.go - cmd/juju/application/deployer/bundlehandler_test.go - cmd/juju/application/deployer/charm_test.go - cmd/juju/application/refresh.go - worker/apiserver/manifold_test.go - worker/apiserver/worker.go Includes: - #13942 - #13888 - #13940 - #13934 - #13939 - #13948 - #13954 - #13933 - #13949 - #13947 - #13956 - #13957 - #13951 - #13958 - #13946 - #13952 - #13950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LXD 5.0.0 introduced this change which breaks not-found error detection in the LXD container manager.
Here, we change the detection to work on a sub-string instead of verbatim "not found".
QA steps
See unit tests.
Documentation changes
None.
Bug reference
https://bugs.launchpad.net/juju/+bug/1968849