Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-1019] Bug 1969929 bundle revision only #13996

Merged
merged 9 commits into from
May 11, 2022
Merged

[JUJU-1019] Bug 1969929 bundle revision only #13996

merged 9 commits into from
May 11, 2022

Commits on May 10, 2022

  1. Add translation of NotValid errors across the wire.

    @hmlanigan
    hmlanigan committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0e45dc0 View commit details
    Browse the repository at this point in the history

  2. Restore error types after results come across the wire. Allows for type 

    checking further down stream.
    @hmlanigan
    hmlanigan committed May 10, 2022
    Configuration menu
    Copy the full SHA
    fecf894 View commit details
    Browse the repository at this point in the history

  3. Moving check on revision and channel flags. 

    Related to LP1969929. There are different checks based on charm or
bundle. However it's unknown which is deploying until the Deployer.
Moving check.
    @hmlanigan
    hmlanigan committed May 10, 2022
    Configuration menu
    Copy the full SHA
    d10c156 View commit details
    Browse the repository at this point in the history

  4. Restore apiserver errors. 

    The call is done inside of core, so it cannot be done there.
    @hmlanigan
    hmlanigan committed May 10, 2022
    Configuration menu
    Copy the full SHA
    288323c View commit details
    Browse the repository at this point in the history

  5. Avoid 'not valid not valid', use NewNotValid instead of NotValidf

    @hmlanigan
    hmlanigan committed May 10, 2022
    Configuration menu
    Copy the full SHA
    eecc41e View commit details
    Browse the repository at this point in the history

  6. Add Code to error messages in test. 

    Needed to pass tests after NotValid errors added to apiserver errors for
translating the type over the wire.
    @hmlanigan
    hmlanigan committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7e90fe3 View commit details
    Browse the repository at this point in the history

  7. Fix misspelling in verified. 

    Co-authored-by: John Arbash Meinel <john@arbash-meinel.com>
    @hmlanigan @jameinel
    hmlanigan and jameinel committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0490775 View commit details
    Browse the repository at this point in the history

  8. Update charm/v8 to pickup change in ParseChannel error types.

    @hmlanigan
    hmlanigan committed May 10, 2022
    Configuration menu
    Copy the full SHA
    9a33ad5 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Add Code to error messages in test. 

    Needed to pass tests after NotValid errors added to apiserver errors for
translating the type over the wire.
    @hmlanigan
    hmlanigan committed May 11, 2022
    Configuration menu
    Copy the full SHA
    cda7fa0 View commit details
    Browse the repository at this point in the history