Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-1225] Fixed broken AKS bootstrap. #14124

Merged
merged 1 commit into from Jun 7, 2022
Merged

Conversation

tlm
Copy link
Member

@tlm tlm commented Jun 7, 2022

AKS has changed the name of their provisioner used in new clusters.
Because of this Juju is unable to bootstrap to newly created AKS
clusters with the error message 'preferred storage "kubernetes.io/azure-disk" not available'.

What this change does is introduce a quick flag for AKS and the other
cloud clusters telling Juju that it is ok to use the default storage
provider. We have done the fix this way in 2.9 because of several bugs
found in the storage processing logic for Juju.

A proper and greater fix will land in 3.0 to address the short comings
of storage.

Fixes lp1976434

Checklist

  • Requires a pylibjuju change
  • Added integration tests for the PR
  • Added or updated doc.go related to packages changed
  • Comments answer the question of why design decisions were made

QA steps

  1. Create a new AKS cluster in Azure
  2. Bootstrap Juju to the newly created cluster and make sure the bootstrap process succeeds.
  3. Add a new model
  4. Deploy postgres juju deploy -n3 postgresql-k8s
  5. Check the postgres deployments comes up with attached storage.

Bug reference

https://bugs.launchpad.net/juju/+bug/1976434

AKS has changed the name of their provisioner used in new clusters.
Because of this Juju is unable to bootstrap to newly created AKS
clusters with the error message 'preferred storage "kubernetes.io/azure-disk" not available'.

What this change does is introduce a quick flag for AKS and the other
cloud clusters telling Juju that it is ok to use the default storage
provider. We have done the fix this way in 2.9 because of several bugs
found in the storage processing logic for Juju.

A proper and greater fix will land in 3.0 to address the short comings
of storage.

Fixes lp1976434
Copy link
Member

@wallyworld wallyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOuld be good to check that deploying a charm with storage eg postgresql-k8s works also

@tlm
Copy link
Member Author

tlm commented Jun 7, 2022

/merge

@jujubot jujubot merged commit 4c2f30c into juju:2.9 Jun 7, 2022
@tlm tlm changed the title Fixed broken AKS bootstrap. [JUJU-1225] Fixed broken AKS bootstrap. Jun 7, 2022
This was referenced Jun 14, 2022
jujubot added a commit that referenced this pull request Jun 20, 2022
#14154

Merge from 2.9 to bring forward:
- #14131 from ycliuhw/fix/lp-1977488
- #14143 from hmlanigan/unused-interface
- #14127 from hmlanigan/remove-rackspace-cloud-registion
- #14136 from wallyworld/fix-race-failure
- #14134 from jameinel/2.9-build-info-metrics
- #14135 from hpidcock/extend-k8s-grace
- #14137 from benhoyt/delete-unused-init-controller
- #14138 from wallyworld/fix-storage-export
- #14120 from jack-w-shaw/JUJU-1177_rewrite_unit_tests
- #14126 from jack-w-shaw/JUJU-1190_drop_acceptance_test_block
- #14128 from wallyworld/azure-deploy-race
- #14125 from jnsgruk/2.9
- #14122 from manadart/2.9-upgrade-test-race
- #14119 from wallyworld/inst-cfg-controller
- #14124 from tlm/lp-1976434-aks-storage
- #14113 from manadart/2.9-multiwatcher-race
- #14115 from tlm/lp-1976620-lxd-filename-expanding
- #14129 from tlm/juju-3.0-k8s-storage-refactor
- #14164 [JUJU-1328] Set snapcraft version to 6.x
- #14155 Validate the input better to avoid confusion
- #14163 [JUJU-1326] Allow series upgrade state to be set by the agent to the same status
- #14142 [JUJU-1273] Check and branch on cloud type when remove-cloud
- #14171 Generate modern ssh host keys for jammy support
- #14167 Add debug log for when the unit series-upgrade status is unchanged
- #14170 [JUJU-1288] Update azure provider to use new Azure SDK
- #14110 [JUJU-1231] Disallow do-release-upgrade for ubuntu controller;

Conflicts:
- apiserver/facades/client/application/package_test.go
- caas/kubernetes/provider/application/application.go
- caas/kubernetes/provider/bootstrap.go
- caas/kubernetes/provider/cloud.go
- caas/kubernetes/provider/cloud_test.go
- caas/kubernetes/provider/metadata.go
- cloudconfig/podcfg/image.go
- cloudconfig/podcfg/podcfg.go
- provider/azure/environ.go
- provider/maas/environ.go
- provider/rackspace/environ.go

[JUJU-1328]: https://warthogs.atlassian.net/browse/JUJU-1328?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-1326]: https://warthogs.atlassian.net/browse/JUJU-1326?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants